Skip to content

mir-opt: Use one MirPatch in MatchBranchSimplification #140080

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

mir-opt: Use one MirPatch in MatchBranchSimplification #140080

wants to merge 1 commit into from

Conversation

dianqk
Copy link
Member

@dianqk dianqk commented Apr 20, 2025

No description provided.

@rustbot
Copy link
Collaborator

rustbot commented Apr 20, 2025

r? @jieyouxu

rustbot has assigned @jieyouxu.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Apr 20, 2025
@rustbot
Copy link
Collaborator

rustbot commented Apr 20, 2025

Some changes occurred to MIR optimizations

cc @rust-lang/wg-mir-opt

@jieyouxu
Copy link
Member

r? mir-opt

@rustbot rustbot assigned wesleywiser and unassigned jieyouxu Apr 20, 2025
@cjgillot
Copy link
Contributor

Is there a test where the opt fires at least twice?

@dianqk
Copy link
Member Author

dianqk commented Apr 21, 2025

Is there a test where the opt fires at least twice?

Perhaps match_nested_if is one:

rust/tests/mir-opt/matches_reduce_branches.rs

Lines 67 to 83 in b8005bf

fn match_nested_if() -> bool {
// CHECK-LABEL: fn match_nested_if(
// CHECK-NOT: switchInt
// CHECK: return
let val = match () {
() if if if if true { true } else { false } { true } else { false } {
true
} else {
false
} =>
{
true
}
_ => false,
};
val
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@wesleywiser wesleywiser

Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@dianqk @rustbot @jieyouxu @cjgillot @wesleywiser